http,net: optimize repeated property access#59968
Open
jbj338033 wants to merge 1 commit intonodejs:mainfrom
Open
http,net: optimize repeated property access#59968jbj338033 wants to merge 1 commit intonodejs:mainfrom
jbj338033 wants to merge 1 commit intonodejs:mainfrom
Conversation
Cache frequently accessed properties to reduce property lookup overhead: - HTTP Agent constructor: Cache `this.options` in local variable to eliminate 14+ property access chains during initialization - net.Socket.setNoDelay: Cache `this._handle` to avoid repeated access - net.Socket.setKeepAlive: Cache `this._handle` to avoid repeated access These optimizations target hot paths in network operations, reducing object traversal overhead during socket configuration and HTTP agent instantiation. Signed-off-by: jbj338033 <jbj338033@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59968 +/- ##
==========================================
+ Coverage 88.41% 88.44% +0.02%
==========================================
Files 703 703
Lines 207421 207426 +5
Branches 39993 40012 +19
==========================================
+ Hits 183398 183448 +50
+ Misses 15996 15945 -51
- Partials 8027 8033 +6
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Sep 24, 2025
Collaborator
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR optimizes repeated property access patterns in network-related modules:
HTTP Agent Constructor (
lib/_http_agent.js)this.optionsin a localoptsvariableSocket Configuration Methods (
lib/net.js)setNoDelay(): Cachesthis._handleto avoid 2 property lookupssetKeepAlive(): Cachesthis._handleto avoid 2 property lookupsPerformance Impact
Test plan