Open
Conversation
MoLow
approved these changes
Feb 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61779 +/- ##
==========================================
- Coverage 89.73% 89.73% -0.01%
==========================================
Files 675 675
Lines 204674 204674
Branches 39330 39327 -3
==========================================
- Hits 183667 183665 -2
- Misses 13283 13295 +12
+ Partials 7724 7714 -10 🚀 New features to boost your workflow:
|
Collaborator
anonrig
approved these changes
Feb 12, 2026
Collaborator
cjihrig
approved these changes
Feb 12, 2026
marco-ippolito
approved these changes
Feb 12, 2026
Member
marco-ippolito
left a comment
There was a problem hiding this comment.
Thanks for fixing this, LGTM
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61779 ✔ Done loading data for nodejs/node/pull/61779 ----------------------------------- PR info ------------------------------------ Title watch: get flags from execArgv (#61779) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch efekrskl:fix/watch-mode-env-collision -> nodejs:main Labels needs-ci Commits 2 - watch: get flags from execArgv - watch: add test for checking cli flag order Committers 1 - Efe Karasakal <dogukankrskl@gmail.com> PR-URL: https://github.com/nodejs/node/pull/61779 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61779 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 11 Feb 2026 20:22:19 GMT ✔ Approvals: 4 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/61779#pullrequestreview-3787523699 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/61779#pullrequestreview-3788303435 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61779#pullrequestreview-3790845539 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/61779#pullrequestreview-3791379219 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-02-12T02:02:21Z: https://ci.nodejs.org/job/node-test-pull-request/71318/ - Querying data for job/node-test-pull-request/71318/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 61779 From https://github.com/nodejs/node * branch refs/pull/61779/merge -> FETCH_HEAD ✔ Fetched commits as 37ff1ea989af..062f3a59e10b -------------------------------------------------------------------------------- [main 87c45433c0] watch: get flags from execArgv Author: Efe Karasakal <dogukankrskl@gmail.com> Date: Wed Feb 11 20:58:01 2026 +0100 1 file changed, 4 insertions(+), 5 deletions(-) [main 3392abc167] watch: add test for checking cli flag order Author: Efe Karasakal <dogukankrskl@gmail.com> Date: Wed Feb 11 21:12:26 2026 +0100 1 file changed, 29 insertions(+) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. (node:394) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- watch: get flags from execArgvhttps://github.com/nodejs/node/actions/runs/22002004722 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61412
This seems to be a regression from cec1bd5, where watch mode switched to spawning the child using getOptionsAsFlagsFromBinding() instead of process.execArgv and the original flag ordering is not preserved.