Skip to content

url: doc deprecate url.resolve#61780

Open
legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas:url-resolve
Open

url: doc deprecate url.resolve#61780
legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas:url-resolve

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Feb 11, 2026

Refs: #61776 (comment)

url.resolve was deprecated but the deprecation was revoked in #37784. Given that url.resolve depends on a deprecated insecure API, it should also be deprecated.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Feb 11, 2026
@legendecas legendecas mentioned this pull request Feb 11, 2026
Closed
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 12, 2026
@richardlau richardlau added the deprecations Issues and PRs related to deprecations. label Feb 12, 2026
@richardlau
Copy link
Member

richardlau commented Feb 12, 2026

We need to update doc/api/deprecations.md, especially since the prior deprecation is marked revoked.

node/doc/api/deprecations.md

Lines 2657 to 2686 in 27ec431

### DEP0116: Legacy URL API
<!-- YAML
changes:
- version:
- v19.0.0
- v18.13.0
pr-url: https://github.com/nodejs/node/pull/44919
description: \`url.parse()` is deprecated again in DEP0169.
- version:
- v15.13.0
- v14.17.0
pr-url: https://github.com/nodejs/node/pull/37784
description: Deprecation revoked. Status changed to "Legacy".
- version: v11.0.0
pr-url: https://github.com/nodejs/node/pull/22715
description: Documentation-only deprecation.
-->
Type: Deprecation revoked
The [legacy URL API][] is deprecated. This includes [`url.format()`][],
[`url.parse()`][], [`url.resolve()`][], and the [legacy `urlObject`][]. Please
use the [WHATWG URL API][] instead.
An automated migration is available ([source](https://github.com/nodejs/userland-migrations/tree/main/recipes/node-url-to-whatwg-url)).
```bash
npx codemod@latest @nodejs/node-url-to-whatwg-url
```

@legendecas
Copy link
Member Author

legendecas commented Feb 13, 2026

Updated doc/api/deprecations.md with history of #61644 as well.

Renegade334
Renegade334 reviewed Feb 13, 2026
View reviewed changes
doc/api/url.md
Comment on lines +1959 to +1961
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/61780
description: Documentation-only deprecation.
Copy link
Member

@Renegade334 Renegade334 Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without #61776, this is actually an application deprecation introduced in v24.0.0. The versioning semantics are a bit tricky, but we shouldn't call this a doc deprecation if it's emitting warnings!

@MikeMcC399 MikeMcC399 mentioned this pull request Feb 14, 2026
Open
@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Feb 14, 2026

This has got a little confusing because of the mixture of issues and decisions about whether the software needs to conform to the documentation or the other way around.

I moved the documentation issue to #61816 and my suggestion is to retroactively document in this PR that #55017 (implicitly) introduced an Application deprecation (non-node_modules code only) for url.resolve() as a dependency of url.parse() in v24.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renegade334 Renegade334 Renegade334 left review comments

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@legendecas @richardlau @MikeMcC399 @anonrig @cjihrig @Renegade334 @nodejs-github-bot