build: use path-ignore in GHA coverage-windows.yml#61811
Open
legendecas wants to merge 1 commit intonodejs:mainfrom
Open
build: use path-ignore in GHA coverage-windows.yml#61811legendecas wants to merge 1 commit intonodejs:mainfrom
legendecas wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Contributor
A test failure doesn't mark the job as failure, no? In this case, is it worth it? I don't think changes on those files would affect the coverage, but could be wrong |
cjihrig
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use similar
paths-ignorein other GHA jobs like.github/workflows/test-macos.ymlto ignore certain changes that do not have effect on builds.This allows changes to
configure.py,node.gyp, orsrc/inspector/node_protocol.pdl, etc, to be tested on GHA windows.For example, windows GHA was not triggered on #61806.