[v24.x backport] build: add support for Visual Studio 2026#61840
Open
MikeMcC399 wants to merge 2 commits intonodejs:v24.x-stagingfrom
Open
[v24.x backport] build: add support for Visual Studio 2026#61840MikeMcC399 wants to merge 2 commits intonodejs:v24.x-stagingfrom
MikeMcC399 wants to merge 2 commits intonodejs:v24.x-stagingfrom
Conversation
This was referenced Feb 15, 2026
Member
|
For releasers, can you prepend |
Backport-PR-URL: nodejs#61840 PR-URL: nodejs#60727 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Backport-PR-URL: nodejs#61840 PR-URL: nodejs#61530 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
1f34ed6 to
25c5353
Compare
Contributor
Author
Thanks for your guidance! I did read in https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#manual-process that it says:
So the instructions aren't really very specific about whose action this is and what is supposed to be done. I have added the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting 2 interrelated PRs:
commit a4b05c1
Author: Michaël Zasso targos@protonmail.com
Date: Wed Nov 19 17:01:37 2025 +0100
commit 25c5353
Author: Stefan Stojanovic stefan.stojanovic@janeasystems.com
Date: Wed Jan 28 15:52:43 2026 +0100
Situation
BUILDING > Supported toolchains for the v24.x branch shows:
With only Visual Studio 2026 Build Tools Edition from https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2026 installed with necessary prerequisites (no side-by-side Visual Studio 2022 installed), executing
.\vcbuildin a PowerShell 7 terminal fails, although the "Supported toolchains" suggest that Visual Studio 2026 should be supported.Change
Cherry-pick 934d907 from #60727
Preserve the
[nocorepack]option invcbuild.batv24.x, which was removed for>=v25.x, to resolve a cherry-pick conflict.Also cherry-pick 5a8864d from #61530 to fix a one line bug in #60727 which prevented selecting Visual Studio 2022 with
.\vcbuild vs2022in a side-by-side configuration where both Visual Studio 2022 and 2026 were installed.Verification
In Windows 11 25H2 with Visual Studio 2022 & 2026 variously installed / not installed, ensure that all valid command combinations of
.\vcbuildrun: