doc: simplify addAbortListener example#61842
Open
atlowChemi wants to merge 2 commits intonodejs:mainfrom
Open
Conversation
a82b1f5 to
83dbc3e
Compare
The example was written before v8 supported the using keyword and hence explicitly called Symbol.dispose Since now the keyword is supported, the example can be simplified
83dbc3e to
b6097b8
Compare
Renegade334
reviewed
Feb 15, 2026
MoLow
reviewed
Feb 16, 2026
| signal.addEventListener('abort', (e) => e.stopImmediatePropagation()); | ||
| // addAbortListener() returns a disposable, so the `using` keyword ensures | ||
| // the abort listener is automatically removed when this scope exits. | ||
| using _ = addAbortListener(signal, (e) => { |
Member
There was a problem hiding this comment.
Suggested change
| using _ = addAbortListener(signal, (e) => { | |
| using listener = addAbortListener(signal, (e) => { |
Member
Author
There was a problem hiding this comment.
This returns an object which only has a disposer, so it really has no use other than the disposal: (so I think giving it a name might be confusing)
node/lib/internal/events/abort_listener.js
Lines 43 to 48 in 1523d66
MoLow
reviewed
Feb 16, 2026
| signal.addEventListener('abort', (e) => e.stopImmediatePropagation()); | ||
| // addAbortListener() returns a disposable, so the `using` keyword ensures | ||
| // the abort listener is automatically removed when this scope exits. | ||
| using _ = addAbortListener(signal, (e) => { |
Member
There was a problem hiding this comment.
Suggested change
| using _ = addAbortListener(signal, (e) => { | |
| using listener = addAbortListener(signal, (e) => { |
MoLow
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example was written before v8 supported the using keyword and hence explicitly called
Symbol.dispose.Since now the keyword is supported, the example can be simplified.