tools: cache V8 build on test-shared workflow#61860
Open
aduh95 wants to merge 2 commits intonodejs:mainfrom
Open
tools: cache V8 build on test-shared workflow#61860aduh95 wants to merge 2 commits intonodejs:mainfrom
aduh95 wants to merge 2 commits intonodejs:mainfrom
Conversation
This commit makes the CI use the Nix/Cachix cache rather than the sccache one for building V8 and its dependencies. This should speed up the average test-shared build time and reduce the stress on the GHA binary cache – at the expense of slower builds when touching a file used to building V8.
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the CI use the Nix/Cachix cache rather than the
sccacheone for building V8 and its dependencies. This should speed up the average test-shared build time and reduce the stress on the GHA binary cache – at the expense of slower builds when touching a file used to building V8.From my testing, building V8 without any
sccachetakes between 1h (on the faster ARM Linux runners) and 2h15 (on slowest Intel Mac runners); on non-mainbranches, where V8 version is more stable and we're disablingsccacheanyway (#61790), this change should be a clear win. Onmain, I guess time will tell.Refs: #61436