doc: clarify build environment is trusted in threat model#61865
Open
mcollina wants to merge 1 commit intonodejs:mainfrom
Open
doc: clarify build environment is trusted in threat model#61865mcollina wants to merge 1 commit intonodejs:mainfrom
mcollina wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
aduh95
approved these changes
Feb 17, 2026
aduh95
reviewed
Feb 17, 2026
Add build system attacks (command injection via environment variables, path hijacking, file permissions) to the list of non-vulnerabilities. The build environment is a trusted element and these scenarios require an already-compromised system.
54981ca to
85e6c7b
Compare
BethGriggs
approved these changes
Feb 17, 2026
RafaelGSS
approved these changes
Feb 17, 2026
atlowChemi
approved these changes
Feb 17, 2026
lpinca
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CC,CXX,PKG_CONFIG,RUSTC), path hijacking in build output directories, and file permissions of build artifacts are not considered vulnerabilitiesThis addresses a recurring class of HackerOne reports that claim vulnerabilities in
configure.pyor other build scripts by manipulating environment variables or the local filesystem. These scenarios require the attacker to already control the build environment, which is a trusted element per the existing threat model.