crypto: fix handling of null BUF_MEM* in ToV8Value()#61885
Open
ndossche wants to merge 2 commits intonodejs:mainfrom
Open
crypto: fix handling of null BUF_MEM* in ToV8Value()#61885ndossche wants to merge 2 commits intonodejs:mainfrom
ndossche wants to merge 2 commits intonodejs:mainfrom
Conversation
The assignment to `bptr` calls `BIO_get_mem_ptr` which can fail and leave the `bptr` as nullptr. This then later causes a null pointer deref. This is inconsistent with uses of the similar function `BIO_get_mem_data` that do check its return value, e.g. `node::crypto::X509sToArrayOfStrings()`. Solve it by checking for a null pointer and handling the `Nothing` return value at the call sites.
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assignment to
bptrcallsBIO_get_mem_ptrwhich can fail and leave thebptras nullptr. This then later causes a null pointer deref.This is inconsistent with uses of the similar function
BIO_get_mem_datathat do check its return value, e.g.node::crypto::X509sToArrayOfStrings().Solve it by checking for a null pointer and handling the
Nothingreturn value at the call sites.Note: this was found by a static-dynamic analyser I'm developing.