crypto: fix missing nullptr check on RSA_new()#61888
Open
ndossche wants to merge 1 commit intonodejs:mainfrom
Open
crypto: fix missing nullptr check on RSA_new()#61888ndossche wants to merge 1 commit intonodejs:mainfrom
ndossche wants to merge 1 commit intonodejs:mainfrom
Conversation
Not checking this can cause a null deref. Since there is already a null check at the bottom of the function with `NewRSA()`.
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61888 +/- ##
==========================================
- Coverage 89.76% 89.74% -0.02%
==========================================
Files 675 674 -1
Lines 204674 204809 +135
Branches 39330 39361 +31
==========================================
+ Hits 183716 183808 +92
- Misses 13235 13272 +37
- Partials 7723 7729 +6
🚀 New features to boost your workflow:
|
addaleax
requested changes
Feb 20, 2026
| KeyType type = d_value->IsString() ? kKeyTypePrivate : kKeyTypePublic; | ||
|
|
||
| RSAPointer rsa(RSA_new()); | ||
| if (!rsa) return {}; |
Member
There was a problem hiding this comment.
Why does this not throw an exception like the other return {}; sites?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not checking this can cause a null deref. Since there is already a null check at the bottom of the function with
NewRSA().Note: this was found by a static-dynamic analyser I'm developing.