Skip to content

Comments

tools: avoid building twice in coverage jobs#61899

Open
aduh95 wants to merge 2 commits intonodejs:mainfrom
aduh95:coverage-build-once
Open

tools: avoid building twice in coverage jobs#61899
aduh95 wants to merge 2 commits intonodejs:mainfrom
aduh95:coverage-build-once

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 20, 2026

I've noticed in https://github.com/nodejs/node/actions/runs/22221357240/job/64277318487 that the workflow builds node twice, it seems that we could simply skip the first build and get the result faster.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 20, 2026

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 20, 2026
@codecov
Copy link

codecov bot commented Feb 20, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.83%. Comparing base (199daab) to head (5ee426d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61899      +/-   ##
==========================================
- Coverage   89.75%   88.83%   -0.92%     
==========================================
  Files         674      674              
  Lines      204886   204886              
  Branches    39376    39293      -83     
==========================================
- Hits       183894   182012    -1882     
- Misses      13280    15096    +1816     
- Partials     7712     7778      +66

see 109 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2026
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x labels Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95 @nodejs-github-bot @lpinca @targos @cjihrig @legendecas