doc: expand SECURITY.md with non-vulnerability examples#61972
Open
RafaelGSS wants to merge 1 commit intonodejs:mainfrom
Open
doc: expand SECURITY.md with non-vulnerability examples#61972RafaelGSS wants to merge 1 commit intonodejs:mainfrom
RafaelGSS wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Renegade334
reviewed
Feb 24, 2026
Comment on lines
+414
to
+421
| #### CRLF Injection in `writeEarlyHints()` | ||
|
|
||
| `ServerResponse.writeEarlyHints()` accepts a `link` header value that is set | ||
| by the application. Passing arbitrary strings, including CRLF sequences, as | ||
| the `link` value is an application-level misuse of the API, not a Node.js | ||
| vulnerability. Node.js validates the structure of Early Hints per the HTTP spec | ||
| but does not sanitize free-form application data passed to it; that is the | ||
| application's responsibility. |
Member
There was a problem hiding this comment.
This one seems a bit specific. I feel like we probably don't need to go down the line of exhaustively listing every received wontfix...
Member
Author
There was a problem hiding this comment.
It's just an attempt to reduce the AI-sloop. If it fixes the problem, we might want to go down that line... in a separate file, possibly more specific to AI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the triage team, most of the reports we are receiving are using IA to fuzz your codebase, making this explicitly on SECURITY.md might avoid that amount of AI Sloop.
cc: @nodejs/security-triage