Skip to content

test: skip test-url on --shared-ada builds#62019

Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:skip-test-url
Open

test: skip test-url on --shared-ada builds#62019
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:skip-test-url

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 27, 2026

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 27, 2026
@panva
Copy link
Member

panva commented Feb 27, 2026

I think we do have the machinery elsewhere already that would allow this to not blanket skip everything

node/test/common/wpt.js

Lines 420 to 439 in 7cf2dad

/**
* @param {Set} requires
* @returns {string|false} The config that the build is lacking, or false
*/
isLacking(requires) {
const current = this.currentIntl;
if (requires.has('full-icu') && current !== kIntlRequirement.full) {
return 'full-icu';
}
if (requires.has('small-icu') && current < kIntlRequirement.small) {
return 'small-icu';
}
if (requires.has('crypto') && !this.hasCrypto) {
return 'crypto';
}
if (requires.has('inspector') && !this.hasInspector) {
return 'inspector';
}
return false;
}

"requires": ["crypto", "inspector", "small-icu"]

Furthermore the status files can be .cjs for setting expectations for individual tests dynamically.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.72%. Comparing base (2ae6d8f) to head (5145814).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62019      +/-   ##
==========================================
- Coverage   89.74%   89.72%   -0.02%     
==========================================
  Files         676      676              
  Lines      206072   206069       -3     
  Branches    39507    39514       +7     
==========================================
- Hits       184936   184902      -34     
- Misses      13303    13310       +7     
- Partials     7833     7857      +24     

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Contributor Author

aduh95 commented Feb 27, 2026

I think we do have the machinery elsewhere already that would allow this to not blanket skip everything

That's true, but tbh that seems hardly worth the maintenance burden, each version of Ada will pass a different subset of the tests.

I've removed the --without-intl check as the failure I was seeing was only related to the Ada version I were using.

@aduh95 aduh95 changed the title test: skip test-url on --without-intl and --shared-ada builds test: skip test-url on --shared-ada builds Feb 27, 2026
@panva
Copy link
Member

panva commented Feb 27, 2026

Ok, if this is limited to shared ada ✅

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2026
@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants