Skip to content

doc: add title to index#62046

Open
avivkeller wants to merge 2 commits intonodejs:mainfrom
avivkeller:title-index
Open

doc: add title to index#62046
avivkeller wants to merge 2 commits intonodejs:mainfrom
avivkeller:title-index

Conversation

@avivkeller
Copy link
Member

A title on this page is needed for the new web generator to populate the navigation.

Copilot AI review requested due to automatic review settings March 1, 2026 00:04
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 1, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a visible title to the API index page so the new web documentation generator can populate navigation labels.

Changes:

  • Add a Markdown heading (“Index”) at the top of doc/api/index.md.
  • Remove an outdated top-of-file comment block.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2026
NB(chrisdickinson): if you move this file, be sure to update
tools/doc/html.mjs to point at the new location.
-->
# Index
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Index
# Node.js documentation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to include the version in which it exists in that title, but I’m not sure if that’s possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to include the version in which it exists in that title, but I’m not sure if that’s possible.

That's already included as a header above this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I apologize, I was referring to the legacy-html documentation when I said the header already existed (which is contradictory to my PR, lol). I do agree that having some kind of version indicator would be nice, however, it would require some sort-of replacing logic on the web generator, which wouldn't be backported to the legacy generator. As such, we should put a 'pin' in that idea, and implement it with #62045.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants