lib,src: implement QuotaExceededError as DOMException-derived interface#62293
Open
panva wants to merge 5 commits intonodejs:mainfrom
Open
lib,src: implement QuotaExceededError as DOMException-derived interface#62293panva wants to merge 5 commits intonodejs:mainfrom
panva wants to merge 5 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Implement QuotaExceededError as a DOMException-derived interface per the WebIDL specification update. QuotaExceededError is now a proper constructor exposed as a global [Exposed=*] interface that extends DOMException with optional `quota` and `requested` attributes (both nullable doubles, defaulting to null). The constructor validates that quota and requested are finite, non-negative, and that requested is not less than quota when both are provided. QuotaExceededError is [Serializable] and supports structuredClone, preserving the quota and requested values across the serialization boundary. Callers updated: - crypto.getRandomValues() now throws a QuotaExceededError instance - WebStorage (C++) now constructs QuotaExceededError directly Refs: https://redirect.github.com/whatwg/webidl/pull/1465 Fixes: nodejs#58987
6449ff6 to
f056a79
Compare
anonrig
reviewed
Mar 17, 2026
| if ('requested' in options) { | ||
| requested = +options.requested; | ||
| if (!NumberIsFinite(requested)) { | ||
| // eslint-disable-next-line no-restricted-syntax |
Member
There was a problem hiding this comment.
Why does this disable line required? It's not obvious...
Member
Author
There was a problem hiding this comment.
Same reason as #62293 (comment), the linter asks to
78:18 error Use an error exported by 'internal/errors' instead no-restricted-syntax
225:17 error Use an error exported by 'internal/errors' instead no-restricted-syntax
230:17 error Use an error exported by 'internal/errors' instead no-restricted-syntax
237:17 error Use an error exported by 'internal/errors' instead no-restricted-syntax
242:17 error Use an error exported by 'internal/errors' instead no-restricted-syntax
248:13 error Use an error exported by 'internal/errors' instead no-restricted-syntax
which we can't here because require() isn't available.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62293 +/- ##
==========================================
- Coverage 89.66% 89.66% -0.01%
==========================================
Files 676 677 +1
Lines 206556 206691 +135
Branches 39552 39583 +31
==========================================
+ Hits 185218 185331 +113
- Misses 13493 13495 +2
- Partials 7845 7865 +20
🚀 New features to boost your workflow:
|
MattiasBuelens
approved these changes
Mar 17, 2026
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
approved these changes
Mar 17, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement QuotaExceededError as a DOMException-derived interface per the WebIDL specification update.
QuotaExceededError is now a proper constructor exposed as a global [Exposed=*] interface that extends DOMException with optional
quotaandrequestedattributes (both nullable doubles, defaulting to null).The constructor validates that quota and requested are finite, non-negative, and that requested is not less than quota when both are provided.
QuotaExceededError is [Serializable] and supports structuredClone, preserving the quota and requested values across the serialization boundary.
Callers updated:
Refs: https://redirect.github.com/whatwg/webidl/pull/1465
Fixes: https://redirect.github.com/nodejs/node/issues/58987
cc @domenic