loader: add experimental text and bytes import#62300
Draft
efekrskl wants to merge 2 commits intonodejs:mainfrom
Draft
loader: add experimental text and bytes import#62300efekrskl wants to merge 2 commits intonodejs:mainfrom
efekrskl wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Contributor
|
Note that the import-bytes proposal requires producing Uint8Arrays backed by immutable ArrayBuffers, which are not yet supported in V8. I would be hesitant to ship this with mutable backing buffers, even flagged as experimental, lest people come to rely on that. Text imports don't have the same problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62082
Adds support for text and bytes import under
--experimental-raw-importsflag.Examples:
Import text is a Stage 3 TC39 proposal
Import bytes is a Stage 2.7 TC39 proposal
Deno supports this under
--unstable-raw-imports(which I drew inspiration from).Bun only supports text imports.
Not entirely sure what the current stance is on not-yet-landed proposals, but putting this up for discussion and feedback.