lib: make SubtleCrypto.supports enumerable#62307
Open
panva wants to merge 2 commits intonodejs:mainfrom
Open
Conversation
Collaborator
|
Review requested:
|
targos
approved these changes
Mar 18, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Refs: web-platform-tests/wpt#58579 |
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62307 +/- ##
==========================================
+ Coverage 89.66% 89.68% +0.01%
==========================================
Files 676 676
Lines 206575 206579 +4
Branches 39555 39552 -3
==========================================
+ Hits 185225 185264 +39
+ Misses 13501 13446 -55
- Partials 7849 7869 +20
🚀 New features to boost your workflow:
|
aduh95
reviewed
Mar 18, 2026
Collaborator
aduh95
approved these changes
Mar 18, 2026
Renegade334
approved these changes
Mar 18, 2026
cjihrig
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per WebIDL § 3.7.7, static operations use the same "define the operations" algorithm as regular operations:
The
[[Enumerable]]: truein step 4 applies to both regular and static operations. JavaScriptstaticclass methods are non-enumerable by default, so we need to explicitly setenumerable: trueonSubtleCrypto.supportsto match the spec just like we do with all other prototype methods.