Skip to content

[v24.x backport] raw key formats support in KeyObject APIs#62455

Merged
aduh95 merged 2 commits intonodejs:v24.x-stagingfrom
panva:backport-62240-to-v24.x
Apr 3, 2026
Merged

[v24.x backport] raw key formats support in KeyObject APIs#62455
aduh95 merged 2 commits intonodejs:v24.x-stagingfrom
panva:backport-62240-to-v24.x

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Mar 27, 2026 •
edited
Loading

Backports #62240 (partially) and #62480 to v24.x

The omitted portion of #62240 is the removal and cleanup of KeyExportJob use in WebCryptoAPI.

@panva panva added crypto Issues and PRs related to the crypto subsystem. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Mar 27, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 27, 2026

Review requested:

  • @nodejs/crypto
  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 27, 2026
@panva panva force-pushed the backport-62240-to-v24.x branch from 5c4faaa to 343e82c Compare March 27, 2026 09:32
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.39702% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.09%. Comparing base (ee23202) to head (541be3a).
⚠️ Report is 5 commits behind head on v24.x-staging.

Files with missing lines Patch % Lines
src/crypto/crypto_keys.cc 68.75% 21 Missing and 49 partials ⚠️
lib/internal/crypto/keys.js 94.97% 8 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           v24.x-staging   #62455    +/-   ##
===============================================
  Coverage          90.08%   90.09%            
===============================================
  Files                672      670     -2     
  Lines             200844   200740   -104     
  Branches           39178    39231    +53     
===============================================
- Hits              180939   180847    -92     
+ Misses             12187    12166    -21     
- Partials            7718     7727     +9
Files with missing lines Coverage Δ
src/crypto/crypto_keys.h 56.60% <ø> (ø)
src/node_errors.h 86.48% <ø> (ø)
lib/internal/crypto/keys.js 95.46% <94.97%> (+0.17%) ⬆️
src/crypto/crypto_keys.cc 72.64% <68.75%> (-1.56%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva force-pushed the backport-62240-to-v24.x branch from 343e82c to d0ecd5f Compare March 27, 2026 12:36
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva force-pushed the backport-62240-to-v24.x branch from d0ecd5f to 8db948b Compare March 27, 2026 14:27
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva marked this pull request as draft March 28, 2026 18:13
@panva panva changed the title [v24.x backport] crypto: add raw key formats support to the KeyObject APIs [v24.x backport] raw key formats support in KeyObject APIs Mar 28, 2026
@panva panva marked this pull request as ready for review March 31, 2026 08:40
@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Mar 31, 2026
@panva panva mentioned this pull request Mar 31, 2026
Merged
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 2, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72438/

panva added 2 commits April 4, 2026 00:01
@panva @aduh95
crypto: add raw key formats support to the KeyObject APIs
54ef940 
PR-URL: nodejs#62240
Backport-PR-URL: nodejs#62455
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva @aduh95
crypto: recognize raw formats in keygen
541be3a 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62480
Backport-PR-URL: nodejs#62455
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the backport-62240-to-v24.x branch from bd10385 to 541be3a Compare April 3, 2026 22:01
@aduh95 aduh95 merged commit 541be3a into nodejs:v24.x-staging Apr 3, 2026
19 checks passed
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Apr 3, 2026

Landed in 7757cc3...541be3a

@panva
Copy link
Copy Markdown
Member Author

panva commented Apr 4, 2026 •
edited
Loading

@aduh95 these 2 aren't released on current yet, they will go out with 26.x, technically there's no harm since these are experimental 1.1 marked additions.

@panva panva deleted the backport-62240-to-v24.x branch April 10, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panva @nodejs-github-bot @aduh95