Skip to content

test_runner: add passed, attempt, and diagnostic to SuiteContext#62504

Open
MoLow wants to merge 2 commits intomainfrom
add-suite-context-properties
Open

test_runner: add passed, attempt, and diagnostic to SuiteContext#62504
MoLow wants to merge 2 commits intomainfrom
add-suite-context-properties

Conversation

@MoLow
Copy link
Copy Markdown
Member

@MoLow MoLow commented Mar 30, 2026

No description provided.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 30, 2026

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 30, 2026
atlowChemi
atlowChemi reviewed Mar 30, 2026
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (d9645d7) to head (3a1675c).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62504      +/-   ##
==========================================
+ Coverage   89.69%   89.70%   +0.01%     
==========================================
  Files         692      692              
  Lines      214039   214051      +12     
  Branches    41064    41059       -5     
==========================================
+ Hits       191985   192022      +37     
+ Misses      14134    14091      -43     
- Partials     7920     7938      +18
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.82% <100.00%> (+0.02%) ⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow MoLow requested a review from atlowChemi March 30, 2026 14:08
@MoLow MoLow added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Mar 30, 2026
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72297/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72308/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72315/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72321/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72323/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 31, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72331/

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@pmarchini pmarchini pmarchini approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow @nodejs-github-bot @benjamingr @pmarchini @atlowChemi