Open
Conversation
Collaborator
|
Review requested:
|
When a socket with pipelined requests is destroyed then some requests will leak.
50c1e4c to
58aded6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62534 +/- ##
==========================================
- Coverage 91.55% 89.71% -1.84%
==========================================
Files 351 695 +344
Lines 147653 214154 +66501
Branches 23224 41022 +17798
==========================================
+ Hits 135179 192134 +56955
- Misses 12217 14070 +1853
- Partials 257 7950 +7693
🚀 New features to boost your workflow:
|
Collaborator
Collaborator
Collaborator
metcoder95
reviewed
Apr 2, 2026
| this.once('socket', function socketDestroyOnConnect(socket) { | ||
| socket.destroy(error); | ||
| }); | ||
| process.nextTick(emitDestroyNT, this); |
Member
There was a problem hiding this comment.
out of curiosity, does queueMicrotask has a different effect on this?
Member
Author
There was a problem hiding this comment.
Hard to tell... the whole task execution is currently undefined behavior. I think we need to at least be consistent in node and always use one or the rother.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a socket with pipelined requests is destroyed then some requests will leak.