Skip to content

src: coerce spawnSync args to string once#62633

Open
aduh95 wants to merge 5 commits intonodejs:mainfrom
aduh95:spawn-sync-args-tostring
Open

src: coerce spawnSync args to string once#62633
aduh95 wants to merge 5 commits intonodejs:mainfrom
aduh95:spawn-sync-args-tostring

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 8, 2026

This also fixes a TOCTOU race condition for objects with non-constant toString returned value.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Apr 8, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 8, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72557/

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.78%. Comparing base (ae1c0e4) to head (e3aa3a3).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/spawn_sync.cc 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62633      +/-   ##
==========================================
- Coverage   89.79%   89.78%   -0.01%     
==========================================
  Files         697      697              
  Lines      215773   215771       -2     
  Branches    41297    41298       +1     
==========================================
- Hits       193749   193729      -20     
- Misses      14117    14132      +15     
- Partials     7907     7910       +3
Files with missing lines Coverage Δ
src/spawn_sync.cc 68.92% <90.00%> (+0.32%) ⬆️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 8, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72559/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aduh95 @nodejs-github-bot