Skip to content

streams: simplify createPromiseCallback#62650

Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:webstreams-createPromiseCallback
Open

streams: simplify createPromiseCallback#62650
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:webstreams-createPromiseCallback

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 9, 2026

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.80%. Comparing base (e6ef477) to head (daa80b1).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62650      +/-   ##
==========================================
- Coverage   89.81%   89.80%   -0.01%     
==========================================
  Files         697      699       +2     
  Lines      215773   216223     +450     
  Branches    41279    41333      +54     
==========================================
+ Hits       193786   194186     +400     
- Misses      14093    14131      +38     
- Partials     7894     7906      +12     
Files with missing lines Coverage Δ
lib/internal/webstreams/util.js 94.53% <100.00%> (-0.11%) ⬇️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the webstreams-createPromiseCallback branch from 07b17a6 to daa80b1 Compare April 9, 2026 20:59
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 9, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 9, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. web streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants