Skip to content

lib,permission: add permission.drop#62672

Open
RafaelGSS wants to merge 2 commits intonodejs:mainfrom
RafaelGSS:add-permission-drop
Open

lib,permission: add permission.drop#62672
RafaelGSS wants to merge 2 commits intonodejs:mainfrom
RafaelGSS:add-permission-drop

Conversation

@RafaelGSS
Copy link
Copy Markdown
Member

@RafaelGSS RafaelGSS commented Apr 10, 2026

Refs: #62223

@RafaelGSS
lib,permission: add permission.drop
e17f890 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS requested a review from mcollina April 10, 2026 14:46
@RafaelGSS RafaelGSS added semver-minor PRs that contain new features and should be released in the next minor version. notable-change PRs with changes that should be highlighted in changelogs. permission Issues and PRs related to the Permission Model labels Apr 10, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 10, 2026

Review requested:

  • @nodejs/security-wg

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @RafaelGSS.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 72.50000% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.71%. Comparing base (586403f) to head (e17f890).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/permission/fs_permission.cc 71.05% 18 Missing and 4 partials ⚠️
src/permission/permission.cc 84.61% 0 Missing and 8 partials ⚠️
lib/internal/process/permission.js 58.33% 5 Missing ⚠️
src/permission/addon_permission.cc 0.00% 3 Missing ⚠️
src/permission/inspector_permission.cc 0.00% 3 Missing ⚠️
src/permission/wasi_permission.cc 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62672      +/-   ##
==========================================
- Coverage   91.52%   89.71%   -1.81%     
==========================================
  Files         354      699     +345     
  Lines      148921   216237   +67316     
  Branches    23352    41280   +17928     
==========================================
+ Hits       136304   194007   +57703     
- Misses      12354    14328    +1974     
- Partials      263     7902    +7639
Files with missing lines Coverage Δ
lib/internal/process/pre_execution.js 97.22% <100.00%> (+13.11%) ⬆️
src/permission/child_process_permission.cc 100.00% <100.00%> (ø)
src/permission/fs_permission.h 90.00% <ø> (ø)
src/permission/net_permission.cc 100.00% <100.00%> (ø)
src/permission/net_permission.h 100.00% <ø> (ø)
src/permission/permission.h 100.00% <ø> (ø)
src/permission/worker_permission.cc 100.00% <100.00%> (ø)
src/permission/addon_permission.cc 62.50% <0.00%> (ø)
src/permission/inspector_permission.cc 62.50% <0.00%> (ø)
src/permission/wasi_permission.cc 62.50% <0.00%> (ø)
... and 3 more

... and 462 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina Awaiting requested review from mcollina

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. permission Issues and PRs related to the Permission Model semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RafaelGSS @nodejs-github-bot