Skip to content

url: align default argument handling for URLPattern with webidl#62708

Open
nodejs-github-bot wants to merge 2 commits intomainfrom
actions/update-urlpattern-wpt
Open

url: align default argument handling for URLPattern with webidl#62708
nodejs-github-bot wants to merge 2 commits intomainfrom
actions/update-urlpattern-wpt

Conversation

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot commented Apr 12, 2026

This is an automated update of the WPT for urlpattern to web-platform-tests/wpt@f07c03c.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 12, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

nodejs-github-bot commented Apr 12, 2026

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 12, 2026
@panva panva mentioned this pull request Apr 12, 2026
Closed
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 12, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 12, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

nodejs-github-bot commented Apr 12, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72658/

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.80%. Comparing base (dfe438d) to head (e35a00e).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62708      +/-   ##
==========================================
- Coverage   89.81%   89.80%   -0.01%     
==========================================
  Files         699      699              
  Lines      216379   216379              
  Branches    41366    41369       +3     
==========================================
- Hits       194340   194326      -14     
- Misses      14139    14141       +2     
- Partials     7900     7912      +12

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 12, 2026
@panva
Copy link
Copy Markdown
Member

panva commented Apr 12, 2026 •
edited
Loading

cc @nodejs/url

  "urlpattern-constructor.any.js": {
    "fail": {
      "unexpected": [
        "Test constructor with undefined"
      ]
    }
  },

@panva panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 12, 2026
@panva
Copy link
Copy Markdown
Member

panva commented Apr 12, 2026 •
edited
Loading

@nodejs/url see 07d3698

@panva panva added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. whatwg-url Issues and PRs related to the WHATWG URL implementation. web-standards Issues and PRs related to Web APIs and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 12, 2026
@panva panva force-pushed the actions/update-urlpattern-wpt branch from bd4e23c to 4d0d15f Compare April 12, 2026 17:25
@panva panva force-pushed the actions/update-urlpattern-wpt branch from 4d0d15f to fc6ba8d Compare April 12, 2026 17:35
@panva panva changed the title test: update WPT for urlpattern to f07c03cbed url: align default argument handling for URLPattern with webidl Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. web-standards Issues and PRs related to Web APIs whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nodejs-github-bot @panva