Document crypto.timingSafeEqual() added in v6.6.0#8796
Closed
madarche wants to merge 1 commit intonodejs:masterfrom
madarche:doc-timingsafeequal-added-in
Closed
Document crypto.timingSafeEqual() added in v6.6.0#8796madarche wants to merge 1 commit intonodejs:masterfrom madarche:doc-timingsafeequal-added-in
madarche wants to merge 1 commit intonodejs:masterfrom
madarche:doc-timingsafeequal-added-in
Conversation
Member
|
If you want, you can reduce the work needed to land this patch by updating the commit message as per https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit. |
not-an-aardvark
approved these changes
Sep 26, 2016
Author
Member
|
@madarche it should include the subsystem and should be 50 chars or less in total. Can I suggest "doc: add added: info for crypto.timingSafeEqual()"? |
crypto.timingSafeEqual() has been added in v6.6.0 cf. #8304 This commit adds the metadata that will display "Added in: v6.6.0" and that can later be checked on https://nodejs.org/api/crypto.html#crypto_crypto_timingsafeequal_a_b
Author
|
@lpinca: Hopefully fixed. Thanks. Didn't think the "subsystem" applied to doc as well |
Member
|
Thank you. |
jasnell
pushed a commit
that referenced
this pull request
Sep 27, 2016
crypto.timingSafeEqual() has been added in v6.6.0 cf. #8304 This commit adds the metadata that will display "Added in: v6.6.0" and that can later be checked on https://nodejs.org/api/crypto.html#crypto_crypto_timingsafeequal_a_b PR-URL: #8796 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
Landed in bb78f65. Thank you! |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
crypto.timingSafeEqual() has been added in v6.6.0 cf. #8304 This commit adds the metadata that will display "Added in: v6.6.0" and that can later be checked on https://nodejs.org/api/crypto.html#crypto_crypto_timingsafeequal_a_b PR-URL: #8796 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
crypto.timingSafeEqual() has been added in v6.6.0 cf. #8304 This commit adds the metadata that will display "Added in: v6.6.0" and that can later be checked on https://nodejs.org/api/crypto.html#crypto_crypto_timingsafeequal_a_b PR-URL: #8796 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Document that the method
crypto.timingSafeEqual()has been added in v6.6.0cf. #8304