Skip to content

Use old-style functions and use safe-buffer #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabrielschulhof wants to merge 1 commit into from
Closed

Use old-style functions and use safe-buffer #122

gabrielschulhof wants to merge 1 commit into from

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Aug 25, 2017

  • err => {} notation doesn't work on Node 4.
  • Run test that uses Buffer.alloc only if ("alloc" in Buffer).

Fixes: #120

gabrielschulhof pushed a commit to gabrielschulhof/node-addon-api that referenced this pull request Aug 25, 2017
Use old-style functions and skip Buffer.alloc test
8a71556 
* err => {} notation doesn't work on Node 4.
* Run test that uses Buffer.alloc only if ("alloc" in Buffer).

Fixes: nodejs#120
PR-URL: nodejs#122
Use old-style functions and use safe-buffer
252e7fe 
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer

Fixes: nodejs#120
PR-URL: nodejs#122
@gabrielschulhof gabrielschulhof changed the title Use old-style functions and skip Buffer.alloc test Use old-style functions and use safe-buffer Aug 25, 2017
@gabrielschulhof gabrielschulhof mentioned this pull request Aug 25, 2017
Closed
mhdawson
mhdawson approved these changes Aug 25, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Aug 25, 2017
@mhdawson
Use old-style functions and use safe-buffer
790de9f 
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer

PR-URL: #122
Fixes: #120
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member

mhdawson commented Aug 25, 2017

Landed as 790de9f

@mhdawson mhdawson closed this Aug 25, 2017
@gabrielschulhof gabrielschulhof deleted the 120-safe-buffer branch August 25, 2017 17:54
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
Use old-style functions and use safe-buffer
2569e91 
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer

PR-URL: nodejs/node-addon-api#122
Fixes: nodejs/node-addon-api#120
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
Use old-style functions and use safe-buffer
510c993 
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer

PR-URL: nodejs/node-addon-api#122
Fixes: nodejs/node-addon-api#120
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
Use old-style functions and use safe-buffer
e93b590 
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer

PR-URL: nodejs/node-addon-api#122
Fixes: nodejs/node-addon-api#120
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Use old-style functions and use safe-buffer
81070f2 
* err => {} notation doesn't work on Node 4.
* Use Buffer.alloc polyfill from safe-buffer

PR-URL: nodejs/node-addon-api#122
Fixes: nodejs/node-addon-api#120
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gabrielschulhof @mhdawson