@NickNaso are you still working on this one?

@mhdawson Yes I'm working on it.

can this also take a prototype argument?

• Are you still working on this?
• Would this be a viable replacement for multiple calls to Napi::Object::Set?

Hi @seishun ,
I'm honest I forgot of this PR. Yes this should be a replacement for multiple calls on Napi::Object::Set. Do you want to work on this ?

Consider this code:

auto object = Napi::Object::New(env):
object.Set("foo", foo);
object.Set("bar", bar);
return object;

If understand correctly, this PR would let one rewrite it as the following (assuming foo and bar are numeric):

return Napi::Object::New({
  Napi::PropertyDescriptor::Value("foo", Napi::Number::New(env, foo)),
  Napi::PropertyDescriptor::Value("bar", Napi::Number::New(env, bar))
});

That's hardly an improvement. Am I missing something?