fix: use 8 characters for commit SHAs#372
Conversation
|
See nodejs/node#30064 (comment) This link works: nodejs/node@d53dd8b0 |
|
Fwiw, I’ve set this to 12 locally, and I’m happy with that. But since most messages here either aren’t user-facing or are supposed to end up on Github where they will be automatically abbreviated anyway, can we maybe go for something even longer or the full SHA? |
|
I'm fine with any length |
GitHub already refused to generate a link with 7.
|
Increased to 12, created an utility function and fixed tests. |
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 75.23% 75.28% +0.05%
==========================================
Files 21 21
Lines 1409 1412 +3
==========================================
+ Hits 1060 1063 +3
Misses 349 349
Continue to review full report at Codecov.
|
GitHub already refused to generate a link with 7.