Feat(brand): add brand resource (#3147)Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> by AugustinMauroy · Pull Request #3147 · nodejs/nodejs.dev

AugustinMauroy · 2023-01-08T16:26:13Z

Description

The idea is that the brand/resource fit with the new design.

Adding brand resources.

The colors
The font
The nodejs logos
Other asset

Related Issues

No related Issues

Check List

I have read the Contributing Guidelines and made commit messages that follow the guideline.
I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
- This is important as most of the cases your code changes might not be correctly linted
I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
I have checked that the build works locally and that npm run build work fine.
I've covered new added functionality with unit tests if necessary.

AugustinMauroy · 2023-01-08T16:28:59Z

CC @nodejs/nodejs-dev

ovflowd · 2023-01-08T16:30:25Z

Oh boii, this is a big one 👀 going to review once I get a few minutes.

github-actions · 2023-01-08T16:36:46Z

Please find a preview at: https://staging.nodejs.dev/3147/

AugustinMauroy · 2023-01-08T16:42:09Z

In local:

In GitHub Staging:

It's 404 error

Have you an idea ?

ovflowd · 2023-01-08T16:45:55Z

Have you an idea ?

This is normal; it's just because it doesn't add the staging prefixes on the link. Don't worry about that.

codecov-commenter · 2023-01-08T18:04:34Z

Codecov Report

Patch coverage has no change and project coverage change: -0.47 ⚠️

Comparison is base (fd57b87) 66.02% compared to head (b7fd195) 65.55%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3147      +/-   ##
==========================================
- Coverage   66.02%   65.55%   -0.47%     
==========================================
  Files         118      145      +27     
  Lines        1351     1742     +391     
  Branches      342      407      +65     
==========================================
+ Hits          892     1142     +250     
- Misses        422      555     +133     
- Partials       37       45       +8

see 197 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ovflowd · 2023-01-18T17:21:21Z

I still haven't had time to review this @shanpriyan would you mind giving an 👁️ here?

shanpriyan · 2023-01-18T17:32:48Z

I still haven't had time to review this @shanpriyan would you mind giving an eye here?

Sure, will look into it.

AugustinMauroy · 2023-01-18T17:43:54Z

I still haven't had time to review this shanpriyan would you mind giving an 👁️ here?

Anyway before merge this pr I wait for an opinion of one or two member of the TSC because we define anyway the logo that the world can use.

shanpriyan

Remove unused .svg files in static/images/ (noticed that accent-colors.svg and full-color.svg are not being used anywhere)
Missing branding.fr.md file

content/about/branding.en.md

src/styles/markdown.scss

content/about/branding.en.md

shanpriyan · 2023-01-18T20:26:57Z

I will test this PR locally once I get time

AugustinMauroy · 2023-01-18T20:48:03Z

Missing branding.fr.md file

view that all the contents to change. It is not added. I will make a pr that will be reviewed by the French team.

AugustinMauroy · 2023-01-18T20:49:00Z

Remove unused .svg files in static/images/ (noticed that accent-colors.svg and full-color.svg are not being used anywhere)

Full colors can be kept to have a summary but the others are not necessary.

content/about/branding.en.md

shanpriyan

Missing icon
The respective logo text should appear below the logo, also the background and border-radius seem a bit weird, Are you sure that's expected?

This PR

Change Nodejs --> Node.js in all occurrences in this PR
Unable to find the difference between these two logos

Also I think the hover state shouldn't appear for logos.
Ref: https://nodejs.dev/en/about/resources/#logo-downloads
Do we need a without background logo that changes according to the theme?
Can we align this in a single row 🤔 ? WDYT

this too

AugustinMauroy · 2023-01-19T19:48:36Z

The respective logo text should appear below the logo

I took this choice because we say what it is and then we show it.

AugustinMauroy · 2023-01-19T19:50:23Z

Can we align this in a single row 🤔 ? WDYT

Yes, but writing html or a react component.

What do you think about doing component react?

shanpriyan · 2023-01-21T08:01:51Z

The respective logo text should appear below the logo

I took this choice because we say what it is and then we show it.

Hmm. IMO the existing one is better.

I wonder what others might think about this approach 🤔

cc: @ovflowd

shanpriyan · 2023-01-21T08:02:30Z

Can we align this in a single row 🤔 ? WDYT

Yes, but writing html or a react component.

What do you think about doing component react?

I think we don't need a react component here

ovflowd · 2023-02-08T22:27:34Z

@AugustinMauroy could you rebase this branch so I could deploy a preview? I want to see how it looks and give my 2cents (opinion) on this PR 👀

github-actions · 2023-02-09T09:39:42Z

Please find a preview at: https://staging.nodejs.dev/3147/

ovflowd

I believe this should be inside a HTML table.

This is also a little bit confusing, mostly because of the sizes of the image. I also believe it should be in a table.

Pretty much you can create a HTML table that has two columns:

The name of the asset and the link to it
Preview of the asset

All asset previews should have a fixed with so that bigger images do not "break the page"

AugustinMauroy · 2023-02-09T20:15:06Z

You mean an html table like this :

name	<img 'same rise'>

ovflowd · 2023-02-27T14:50:18Z

Yes! Something like that! I apologise for the late reply 😅

ovflowd · 2023-03-10T18:59:46Z

@AugustinMauroy can you update this PR please?

AugustinMauroy · 2023-03-10T19:02:56Z

@AugustinMauroy can you update this PR please?

What is it about?

ovflowd · 2023-03-15T09:18:38Z

I'm waiting for you to finish updating this PR with the table I asked for.

AugustinMauroy · 2023-03-15T09:35:15Z

I'm waiting for you to finish updating this PR with the table I asked for.

It's done

github-actions · 2023-03-15T10:16:07Z

Please find a preview at: https://staging.nodejs.dev/3147/

ovflowd

Good! Let's get this merged 🎉

AugustinMauroy added the create-preview Generate preview on staging.nodejs.dev label Jan 8, 2023

AugustinMauroy temporarily deployed to firebase-staging January 8, 2023 16:29 — with GitHub Actions Inactive

github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Jan 8, 2023

shanpriyan suggested changes Jan 18, 2023

View reviewed changes

ovflowd reviewed Jan 19, 2023

View reviewed changes

content/about/branding.en.md Outdated Show resolved Hide resolved

shanpriyan suggested changes Jan 19, 2023

View reviewed changes

shanpriyan added the create-preview Generate preview on staging.nodejs.dev label Jan 21, 2023

shanpriyan had a problem deploying to firebase-staging January 21, 2023 08:02 — with GitHub Actions Failure

github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Jan 21, 2023

AugustinMauroy added 4 commits February 9, 2023 00:23

feat(about): update ressources

6867398

feat(brand): add brand svg

2e0402b

feat(brand): add brand page to about section

e422c70

feat(branding): add snapshots

b19f3a5

ovflowd suggested changes Feb 9, 2023

View reviewed changes

chore(brand): update branding ressource

1fc481d

AugustinMauroy requested review from ovflowd and shanpriyan and removed request for ovflowd and shanpriyan February 15, 2023 21:01

ovflowd and others added 2 commits February 27, 2023 15:50

Merge branch 'main' into ressources

9735f5f

Merge branch 'main' into ressources

969f728

Merge branch 'main' into ressources

b7fd195

Merge branch 'main' into ressources

749f2d4

shanpriyan added the create-preview Generate preview on staging.nodejs.dev label Mar 15, 2023

shanpriyan deployed to firebase-staging March 15, 2023 10:08 — with GitHub Actions View deployment

github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Mar 15, 2023

Merge branch 'main' into ressources

2e9cb4e

ovflowd approved these changes Mar 20, 2023

View reviewed changes

ovflowd changed the title ~~Feat(brand): add brand resource~~ Feat(brand): add brand resource (#3147)Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Mar 20, 2023

ovflowd merged commit 82b7353 into nodejs:main Mar 20, 2023

Comments

Conversation

AugustinMauroy commented Jan 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

AugustinMauroy commented Jan 8, 2023

Uh oh!

ovflowd commented Jan 8, 2023

Uh oh!

github-actions bot commented Jan 8, 2023

Uh oh!

AugustinMauroy commented Jan 8, 2023

Uh oh!

ovflowd commented Jan 8, 2023

Uh oh!

codecov-commenter commented Jan 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ovflowd commented Jan 18, 2023

Uh oh!

shanpriyan commented Jan 18, 2023

Uh oh!

AugustinMauroy commented Jan 18, 2023

Uh oh!

shanpriyan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shanpriyan commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AugustinMauroy commented Jan 18, 2023

Uh oh!

AugustinMauroy commented Jan 18, 2023

Uh oh!

Uh oh!

shanpriyan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy commented Jan 19, 2023

Uh oh!

AugustinMauroy commented Jan 19, 2023

Uh oh!

shanpriyan commented Jan 21, 2023

Uh oh!

shanpriyan commented Jan 21, 2023

Uh oh!

ovflowd commented Feb 8, 2023

Uh oh!

github-actions bot commented Feb 9, 2023

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy commented Feb 9, 2023

Uh oh!

ovflowd commented Feb 27, 2023

Uh oh!

ovflowd commented Mar 10, 2023

Uh oh!

AugustinMauroy commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovflowd commented Mar 15, 2023

Uh oh!

AugustinMauroy commented Mar 15, 2023

Uh oh!

github-actions bot commented Mar 15, 2023

Uh oh!

ovflowd left a comment

AugustinMauroy commented Jan 8, 2023 •

edited

Loading

codecov-commenter commented Jan 8, 2023 •

edited

Loading

shanpriyan commented Jan 18, 2023 •

edited

Loading

shanpriyan left a comment •

edited

Loading

AugustinMauroy commented Mar 10, 2023 •

edited

Loading