This repository was archived by the owner on Apr 26, 2024. It is now read-only.
docs: Updated node-process-nexttick.en.md #3266
Merged
aymen94 merged 2 commits intonodejs:mainfrom Mar 13, 2023
Merged
Conversation
setImmediate invocation should be before the setTimeout invocation to maintain the order of the logged numbers. Signed-off-by: Abhishek Guha <66299749+abhishekguha95@users.noreply.github.com>
ovflowd
approved these changes
Mar 13, 2023
Member
ovflowd
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your first contribution!
AugustinMauroy
suggested changes
Mar 13, 2023
Member
AugustinMauroy
left a comment
There was a problem hiding this comment.
The change is code is good. But output isn't good.
So I'm not in favor of this change.
Member
Sorry, what is wrong with the output? |
Member
Oups nothing error with NVM. So I take to old version. |
AugustinMauroy
approved these changes
Mar 13, 2023
Member
AugustinMauroy
left a comment
There was a problem hiding this comment.
LGTM 👍! Thanks for your first contribution and welcome.
aymen94
approved these changes
Mar 13, 2023
Member
|
LGTM 👌, Thanks for your first contribution!^_^ |
Contributor
Author
|
Thank you for the kind words! This was my 1st open-source contribution. I'm grateful for the opportunity and look forward to continuing to do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the invocation sequence of setTimeout , setImmediate and output logs to maintain output numbering order. ie. 1 -> 2 -> 3 -> 4.
Related Issues
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.