Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Comments

Manipulating-files - Update verbs to be grammatically correct#3268

Merged
shanpriyan merged 2 commits intonodejs:mainfrom
zeemanUka:main
Mar 16, 2023
Merged

Manipulating-files - Update verbs to be grammatically correct#3268
shanpriyan merged 2 commits intonodejs:mainfrom
zeemanUka:main

Conversation

@zeemanUka
Copy link
Contributor

@zeemanUka zeemanUka commented Mar 15, 2023

Description

I updated the verbs in the Manipulating files section in the learn folder by adding "s" to the verb get.

Related Issues

https://nodejs.dev/en/learn/nodejs-file-paths/

Check List

Yes, I have gone through all the check lists.

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution :)

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -1.29 ⚠️

Comparison is base (fd57b87) 66.02% compared to head (aa6df80) 64.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
- Coverage   66.02%   64.73%   -1.29%     
==========================================
  Files         118      145      +27     
  Lines        1351     1764     +413     
  Branches      342      411      +69     
==========================================
+ Hits          892     1142     +250     
- Misses        422      573     +151     
- Partials       37       49      +12     

see 197 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@zeemanUka
Copy link
Contributor Author

LGTM! Thank you for your contribution :)

Thank you so much for the opportunity, I look forward to contributing more.

@zeemanUka
Copy link
Contributor Author

LGTM. Thanks!

You are welcome, thank you for the opportunity.

@shanpriyan shanpriyan merged commit d1a2ab2 into nodejs:main Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants