This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Closed
Conversation
Added additional styling to match the mockup more closely
Codecov Report
@@ Coverage Diff @@
## staging #418 +/- ##
==========================================
Coverage ? 27.69%
==========================================
Files ? 37
Lines ? 455
Branches ? 129
==========================================
Hits ? 126
Misses ? 313
Partials ? 16
Continue to review full report at Codecov.
|
Contributor
Author
|
/gcbrun |
Contributor
Author
|
@benhalverson I just noticed this Chrome vs. Safari
I think we can close this regardless but, this needs to be a separate PR… thoughts? |
Member
|
Yes it should be a new PR against staging since my branch is merged and closed. |
Contributor
Author
|
Closing after opening #422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new
--color-fill-top-bannercustom property in tokens.css using alpha blending to match light and dark.This also restructures the pill-button as
<a><button>instead of<button><a>to avoid the clashing hover color of the text. As a result, it was possible to refactor its styling as a singlebannerButtoninstead ofbannerCtaandbannerButtonText.Screen Shots
Live Build
Feb29https://storage.googleapis.com/staging.nodejs.dev/a003e53/index.htmlRelated Issues
#398