Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
BethGriggs
approved these changes
May 3, 2023
ovflowd
approved these changes
May 3, 2023
Member
Author
|
Needs two approving reviews? That may be a problem sometimes (blog post should be published ASAP after the release is promoted). |
Member
|
@targos we can create bypass rules for releasers. |
Member
Author
|
Can we bypass only this rule? I don't want to bypass CI workflows. |
Member
|
Which rule? (Amount of reviewers?) |
Member
Author
|
Yes, amount of reviewers. |
Member
|
I don't think there's bypass for an individual requirement. Let me check on OpenJS Slack. |
Member
Author
|
If necessary, we can create a separate ruleset for this requirement. btw GitHub deployed a new way to define rules recently: https://github.com/nodejs/nodejs.org/settings/rules |
Member
|
I applied a few rules, @targos! Let's check if next time they work well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#47820