Clarify node-version requirement in trusted-publishers.mdx#1758
Clarify node-version requirement in trusted-publishers.mdx#1758Swimburger wants to merge 1 commit intonpm:mainfrom
Conversation
Added comment to clarify node-version requirement.
|
That error doesn't really fully explain this change. Also I don't think a comment in an example workflow is the best place to specify that information. |
|
Agreed, but it would've saved me a lot of time. Any way to have user's not run into that error would be great. Right now it's not clear that this node version is required to avoid this error. |
|
The section that follows and includes "critical requirement" could be expanded to also specify that you need to be on a supported node version. |
|
It's not just a supported version of Node, because when I ran |
What's the node version by default? It's possible the default node version ships with an old version of npm that had a windows bug with updating. |
|
I'm using Here's the workflow file: name: ci
on: [push]
jobs:
publish:
runs-on: ubuntu-latest
permissions:
id-token: write
steps:
- name: Checkout repo
uses: actions/checkout@v4
- name: Set up node
uses: actions/setup-node@v4
- name: Update npm
run: |
node -v
npm -v
npm install -g npm@latest
node -v
npm -v
- name: Install pnpm
uses: pnpm/action-setup@v4
- name: Install dependencies
run: pnpm install
- name: Build
run: pnpm build
- name: Publish to npm
run: npm publish --access public |
Added comment to clarify node-version requirement.