Skip to content

Conversation

@jamietanna
Copy link
Member

@jamietanna jamietanna commented Mar 4, 2024

No description provided.

@jamietanna jamietanna added this to the v2.2.0 milestone Apr 15, 2024
@jamietanna jamietanna force-pushed the chore/docs branch 7 times, most recently from b150d8f to ac88a7e Compare April 20, 2024 17:32
Also, so we have a central location to look for supported extensions.
@jamietanna jamietanna force-pushed the chore/docs branch 3 times, most recently from d9f9382 to 0ff87a6 Compare April 20, 2024 19:39
Jamie Tanna and others added 18 commits April 20, 2024 20:42
So the comments will appear in i.e. pkg.go.dev and IDEs.
To make it easier for our users to understand the configuration options
that they're able to use, we can introduce a JSON schema that can be
used by an IDE or Language Server Protocol (LSP) implementation to
validate + provide autocomplete.

We make sure to use `additionalProperties: false` to make it super clear
when there's no additional properties possible, which will also make it
clearer when we have items in our configuration which may not be valid,
or from a newer version of `oapi-codegen` that's in use.

Closes #1546.
Now we've got a JSON schema (via #1546) we can use for IDE visibility
into fields, we should apply it to all our configuration.

We'll use the `yaml-language-server` config as that's what I'm using
locally.
jamietanna and others added 2 commits April 20, 2024 20:46
As well as the Petstore, it'd be nice to have a super lightweight
endpoint to show - in as few lines as possible - how to produce an
`oapi-codegen` implementation.
I've been thinking for some time we should rethink the documentation
we've got, as it's been feeling a little bit underdocumented, a bit of a
mixed voice, and we've also had not-that-actionable examples for all the
functionality.

This is the culmination of ~7 weeks of rewriting, alongside the addition
of new examples.

Closes #1254.

Co-authored-by: Jamie Tanna <jamie.tanna@elastic.co>
@jamietanna jamietanna added documentation chore Any maintenance tasks that are regular, not as important to call out in the changelog labels Apr 20, 2024
@jamietanna jamietanna changed the title docs: revamp README and add a CONTRIBUTING.md docs: revamp README, add a CONTRIBUTING.md and add a JSON Schema for configuration files Apr 20, 2024
@jamietanna jamietanna added the enhancement New feature or request label Apr 20, 2024
@jamietanna jamietanna marked this pull request as ready for review April 20, 2024 19:48
@jamietanna jamietanna merged commit 50a552a into master Apr 20, 2024
@jamietanna jamietanna deleted the chore/docs branch April 20, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Any maintenance tasks that are regular, not as important to call out in the changelog documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants