fix: correctly register Fiber middleware #1615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in #1469, when registering custom middleware for Fiber, the server panics. This is because Fiber expects a specific type, but accepts: func (fiber.Router) Use(args ...interface{}) fiber.Router This resolves this by ensuring that we always wrap our middleware functions in a Fiber-compatible handler. We also add a regression test for this use case. Closes #1469. Co-authored-by: emdfonseca <emdfonseca@users.noreply.github.com>
815908e to
eeba9d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1469, when registering custom middleware for Fiber, the
server panics.
This is because Fiber expects a specific type, but accepts:
This resolves this by ensuring that we always wrap our middleware
functions in a Fiber-compatible handler.
We also add a regression test for this use case.
Closes #1469.
Co-authored-by: emdfonseca emdfonseca@users.noreply.github.com