Skip to content

Conversation

@magnetikonline
Copy link
Contributor

Just noted a small typo in the root README.md, the line outlining the use of the prefer-skip-optional-pointer-with-omitzero refers to itself, not the option of prefer-skip-optional-pointer above it.

Actually noted this in the https://github.com/oapi-codegen/oapi-codegen/releases/tag/v2.5.0 release notes (which also needs fixing) - so assume this was cut and pasted from the README.md -> into the release notes.

…o - reference back to `prefer-skip-optional-pointer`
@magnetikonline magnetikonline requested a review from a team as a code owner July 16, 2025 00:38
@kusari-inspector
Copy link

kusari-inspector bot commented Jul 16, 2025

Kusari Analysis Results

Analysis for commit: 90507a8, performed at: 2025-07-16T06:57:16Z

@kusari-inspector rerun - Trigger a re-analysis of this PR

@kusari-inspector feedback [your message] - Send feedback to our AI and team


Recommendation

✅ PROCEED with this Pull Request

Summary

No Flagged Issues Detected

All values appear to be within acceptable risk parameters.

No pinned version dependency changes, code issues or exposed secrets detected!

Found this helpful? Give it a 👍 or 👎 reaction!

- `prefer-skip-optional-pointer`: a global default that you do _not_ want the "optional pointer" generated. Optional fields will not have an "optional pointer", and will have an `omitempty` JSON tag
- `prefer-skip-optional-pointer-with-omitzero`: when used in conjunction with `prefer-skip-optional-pointer-with-omitzero`, any optional fields are generated with an `omitzero` JSON tag. **Requires Go 1.24+**
- `prefer-skip-optional-pointer`: a global default that you do _not_ want the "optional pointer" generated. Optional fields will not have an "optional pointer", and will have an `omitempty` JSON tag.
- `prefer-skip-optional-pointer-with-omitzero`: when used in conjunction with `prefer-skip-optional-pointer`, any optional fields are generated with an `omitzero` JSON tag. **Requires Go 1.24+**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/prefer-skip-optional-pointer-with-omitzero/prefer-skip-optional-pointer/.

@kusari-inspector
Copy link

Kusari PR Analysis rerun based on - 90507a8 performed at: 2025-07-16T06:57:16Z - link to updated analysis

Copy link
Member

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good spot

@jamietanna jamietanna enabled auto-merge (squash) July 16, 2025 06:58
@jamietanna
Copy link
Member

I've also amended the release notes 👍🏼

@jamietanna jamietanna merged commit 635bb4e into oapi-codegen:main Jul 16, 2025
20 checks passed
@magnetikonline
Copy link
Contributor Author

I've also amended the release notes 👍🏼

Yep, https://github.com/oapi-codegen/oapi-codegen/releases/tag/v2.5.0 looks solid now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants