Skip to content

feat(client): add abbility to set custom marshal/unmarshal func for client #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sterligov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(client): add abbility to set custom marshal/unmarshal func for client #2047

sterligov wants to merge 1 commit into from

Conversation

@sterligov
Copy link

@sterligov sterligov commented Aug 2, 2025 •
edited
Loading

In this pull request I added the ability to set custom marshal/unmarshal functions for the client.
This functionality is enabled via the client-custom-marshaler-funcs option.

The default marshal/unmarshal function of json is not the most optimal, I want to be able to marshal/unmarshal for example using the sonic package

@sterligov sterligov requested a review from a team as a code owner August 2, 2025 06:58
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 2, 2025 •
edited
Loading

Kusari Analysis Results

Analysis for commit: c3b85f9, performed at: 2025-08-02T17:18:59Z

• @kusari-inspector rerun - Trigger a re-analysis of this PR

• @kusari-inspector feedback [your message] - Send feedback to our AI and team

Recommendation

✅ PROCEED with this Pull Request

Summary

✅ No Flagged Issues Detected

All values appear to be within acceptable risk parameters.

No pinned version dependency changes, code issues or exposed secrets detected!

Found this helpful? Give it a 👍 or 👎 reaction!

@jamietanna
Copy link
Member

jamietanna commented Aug 2, 2025

Thanks - will review in more depth at some point, but the immediate thought I have is that this should be an opt-in config via output-options - see https://github.com/oapi-codegen/oapi-codegen/blob/main/CONTRIBUTING.md#making-changes-that-tweak-generated-code for a bit more info

Thanks!

@kusari-inspector
Copy link

kusari-inspector bot commented Aug 2, 2025

Kusari PR Analysis rerun based on - 1e5d4c6 performed at: 2025-08-02T14:54:48Z - link to updated analysis

@sterligov sterligov force-pushed the feat-client-custom-unmarshaler branch from 1e5d4c6 to 70bd546 Compare August 2, 2025 15:00
@sterligov sterligov changed the title feat(client): added the ability to set custom unmarshallers in the client feat(client): add abbility to set custom marshal/unmarshal func for client Aug 2, 2025
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 2, 2025

Kusari PR Analysis rerun based on - 70bd546 performed at: 2025-08-02T15:00:22Z - link to updated analysis

@sterligov sterligov force-pushed the feat-client-custom-unmarshaler branch from 70bd546 to 8e05e4c Compare August 2, 2025 15:04
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 2, 2025

Kusari PR Analysis rerun based on - 8e05e4c performed at: 2025-08-02T15:04:34Z - link to updated analysis

@sterligov sterligov marked this pull request as draft August 2, 2025 15:05
@sterligov sterligov force-pushed the feat-client-custom-unmarshaler branch from 8e05e4c to 246ecb0 Compare August 2, 2025 15:07
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 2, 2025

Kusari PR Analysis rerun based on - 246ecb0 performed at: 2025-08-02T15:07:48Z - link to updated analysis

@sterligov sterligov marked this pull request as ready for review August 2, 2025 15:09
@sterligov
Copy link
Author

sterligov commented Aug 2, 2025

Thanks - will review in more depth at some point, but the immediate thought I have is that this should be an opt-in config via output-options - see https://github.com/oapi-codegen/oapi-codegen/blob/main/CONTRIBUTING.md#making-changes-that-tweak-generated-code for a bit more info

Thanks!

I added a flag client-custom-marshaler-funcs that, when enabled, generates additional code that allows you to set custom marshalling functions

@sterligov sterligov force-pushed the feat-client-custom-unmarshaler branch from 246ecb0 to 12c021d Compare August 2, 2025 15:13
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 2, 2025

Kusari PR Analysis rerun based on - 12c021d performed at: 2025-08-02T15:13:34Z - link to updated analysis

@sterligov sterligov force-pushed the feat-client-custom-unmarshaler branch from 12c021d to e6e35e0 Compare August 2, 2025 15:14
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 2, 2025

Kusari PR Analysis rerun based on - e6e35e0 performed at: 2025-08-02T15:14:33Z - link to updated analysis

@sterligov sterligov force-pushed the feat-client-custom-unmarshaler branch from e6e35e0 to fab5f2d Compare August 2, 2025 15:31
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 2, 2025

Kusari PR Analysis rerun based on - fab5f2d performed at: 2025-08-02T15:31:04Z - link to updated analysis

@sterligov sterligov force-pushed the feat-client-custom-unmarshaler branch from fab5f2d to aa6e275 Compare August 2, 2025 16:02
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 2, 2025

Kusari PR Analysis rerun based on - aa6e275 performed at: 2025-08-02T16:02:47Z - link to updated analysis

@sterligov sterligov force-pushed the feat-client-custom-unmarshaler branch from aa6e275 to c3b85f9 Compare August 2, 2025 17:18
@kusari-inspector
Copy link

kusari-inspector bot commented Aug 2, 2025

Kusari PR Analysis rerun based on - c3b85f9 performed at: 2025-08-02T17:18:59Z - link to updated analysis

@CJourneaux CJourneaux mentioned this pull request Nov 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

client

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sterligov @jamietanna