Skip to content

Tags: oliverdunk/wpt

Tags

merge_pr_17581

Toggle merge_pr_17581's commit message
Revert "Fix first line style caching issues"

This reverts commit 228ee33446fc20cef8fcc94503a91c16bbcfc6fb.

Reason for revert: Clusterfuzz found several bugs caused by the CL.

Original change's description:
> Fix first line style caching issues
>
> 1. Cache conflict issue:
>
> Previously calls to Element:: Element::CachedStyleForPseudoElement()
> with different second parameters caused cache conflict. The second
> call to it might get unwanted result that was cached with a different
> second parameter.
>
> Now remove the second parameter, and the function gets and caches the
> pseudo style only based on its own computed style. If a caller wants
> a pseudo style based on another style, the caller should call
> Element::UncachedStyleForPseudoElement() and manage cache by itself.
>
> 2. Under-invalidation on change
>
> Cached first line style needs invalidation in two cases:
> a) when the ::first-line style changes, we should invalidate all
>    cached first line styles affected.
> b) when style of an inline element (which inherits ::first-line
>    style) changes, as the inline element's style has higher priority
>    than the inherited ::first-line style, even if the style doesn't
>    change, we need to invalidate the cached
>    kPseudoIdFirstLineInherited style if the new style is different
>    from the inherited ::first-line style.
>
> Bug: 979054
>
> Change-Id: Icffe68d5136349d12cce6e92d1d3bf153c28903a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678878
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#673574}

TBR=wangxianzhu@chromium.org,fs@opera.com,futhark@chromium.org

Change-Id: Ief1eb5749624f877e04d7bff19f42c6f94844b70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 979054, 979961, 979942, 979940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682282
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673594}

merge_pr_17561

Toggle merge_pr_17561's commit message
Fix first line style caching issues

1. Cache conflict issue:

Previously calls to Element:: Element::CachedStyleForPseudoElement()
with different second parameters caused cache conflict. The second
call to it might get unwanted result that was cached with a different
second parameter.

Now remove the second parameter, and the function gets and caches the
pseudo style only based on its own computed style. If a caller wants
a pseudo style based on another style, the caller should call
Element::UncachedStyleForPseudoElement() and manage cache by itself.

2. Under-invalidation on change

Cached first line style needs invalidation in two cases:
a) when the ::first-line style changes, we should invalidate all
   cached first line styles affected.
b) when style of an inline element (which inherits ::first-line
   style) changes, as the inline element's style has higher priority
   than the inherited ::first-line style, even if the style doesn't
   change, we need to invalidate the cached
   kPseudoIdFirstLineInherited style if the new style is different
   from the inherited ::first-line style.

Bug: 979054

Change-Id: Icffe68d5136349d12cce6e92d1d3bf153c28903a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678878
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673574}

merge_pr_17437

Toggle merge_pr_17437's commit message
HTML: test that changing <iframe srcdoc> processes attributes

merge_pr_17570

Toggle merge_pr_17570's commit message
HTML: applet no longer exists

For HTML purposes that's "worse" than obsolete.

In the same directory there's historical.html to ensure it won't be added again.

Fixes web-platform-tests#17559.

merge_pr_17566

Toggle merge_pr_17566's commit message
Fix wpt/inert/inert-retargeting-iframe.tentative.html

TBR=poromov@chromium.org
TBR=schenney@chromium.org

Bug: 979193
Change-Id: I12f73886f3fc42ef5da205ae6f4387ed2a0ed13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680471
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673212}

merge_pr_17556

Toggle merge_pr_17556's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sync Mozilla CSS tests as of https://hg.mozilla.org/mozilla-central/r…

…ev/a72f0a08f652ab309328230659c97660e13cfd27 . (web-platform-tests#17556)

This contains changes from [bug 1561717](https://bugzilla.mozilla.org/show_bug.cgi?id=1561717), mostly by @MReschenberg and reviewed by @dholbert, with fixups by @dholbert and reviewed by me.

merge_pr_17546

Toggle merge_pr_17546's commit message
Add default role status to toast

BUG=972945

Change-Id: I95350e551d83f84ba26be8ce9d0bfaf8fad9aea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675282
Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673153}

merge_pr_17543

Toggle merge_pr_17543's commit message
Fix crash when setting invalid @font-face descriptors via CSSOM.

When @font-face rules are parsed normally (as part of a stylesheet),
the descriptors are parsed with CSSParserToken::ParseAsAtRuleDescriptorID,
which is allowed to return kInvalid.

However, when using CSSOM, the parsing takes a different path that first
creates a CSSPropertyID, then converts it to a AtRuleDescriptorID using
CSSPropertyIDAsAtRuleDescriptor, which *isn't* allowed to return kInvalid.

Fix by allowing kInvalid, and gracefully handling this in
CSSPropertyParser::ParseFontFaceDescriptor.

Note that this is the only callsite for CSSPropertyIDAsAtRuleDescriptor.

BUG=977953

Change-Id: I42081dd4bae3c828843be3ca994ff4f48d06a7f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676629
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673262}