Merged
Conversation
7c01755 to
e9d0b98
Compare
Contributor
peterdudfield
left a comment
There was a problem hiding this comment.
Good work Simon. That tidies up some code nicely
d660113 to
a3754f0
Compare
Instead of copy pasting a lot of code between workflows, we reuse "atomic" workflows. In particular we fix the workflow that bumps the version and we add one that solely build and publishes a docker image. Also: * Support submodules in docker-release-only workflow * Rename "new_tag" -> "new_ver" * Bump jasonamyers/github-bumpversion-action to 1.0.5 * Uniformize job names * Remove `workdir` option (it wasn't used anywhere)
db4eed6 to
46ca1a7
Compare
2 tasks
peterdudfield
approved these changes
Mar 21, 2023
Contributor
peterdudfield
left a comment
There was a problem hiding this comment.
Great stuff @simlmx - thanks for reorganisation this
This was referenced Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of copy pasting a lot of code between workflows, we reuse
"atomic" workflows. In particular we fix the workflow that bumps the
version and we add one that solely build and publishes a docker image.
This was required in the
pv-site-productionrepo where we bump1 version but release 2 dockers.
Also:
docker-release-onlyworkflowworkdiroption (it wasn't used anywhere)Tests
Everything should be backward compatible. To make sure I ran all the workflows in another repo whose sole purpose is to test our organization-level workflows.
Still, if any repo were to break, we could pin the version of the workflows to
@v1.0.0(the previous version) instead of@main.Release
After I merge this PR I'll release as
v1.1.0and also havev1point tov1.1.0.