🌱 Add override labeling for go-apidiff#2565
🌱 Add override labeling for go-apidiff#2565tmshort wants to merge 1 commit intooperator-framework:mainfrom
Conversation
Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR adds an override mechanism to the go-apidiff GitHub Actions workflow, allowing PRs with the go-apidiff-override label to bypass API diff failures. This unblocks PR #2538 which introduces new/changed APIs that trigger apidiff failures.
Changes:
- Makes the
go-apidiffstep non-blocking viacontinue-on-error: trueand adds a follow-up step that fails the job only if apidiff failed and the PR lacks thego-apidiff-overridelabel.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
We can't get #2538 to merge without disabling go-apidiff
Description
Reviewer Checklist