fix: Remove @babel/runtime as a peerDependency#935
fix: Remove @babel/runtime as a peerDependency#935kirkeaton wants to merge 1 commit intooptimizely:masterfrom
Conversation
|
Hiya @kirkeaton, Thanks for the suggestion. We love slimming down the deps wherever possible. Could you let us know what problem this solves for your use case (management needs doc 🙄 😁 ). |
|
I'll do my best to summarize what I see as the problem. I believe that this dependency is not used within this project. I inspected the build artifacts and did not find it being used and it's not mentioned in the installation docs (here or here). Since it's listed as a peer dependency, developers may think that they need to install this dependency in their own project in order for this SDK to work properly. Additionally, some package managers will output a warning message if a peer dependency is not installed. By removing it, this warning message will go away. Here's an example screenshot of the warning message:
Hope this explanation helps. |
|
@kirkeaton That's super detailed. Thanks for taking your time to put in the PR and the description. I've created internal work item FSSDK-10320 which we'll fold this change into the next release. |
|
Hi @kirkeaton , could you please read the CONTRIBUTING.md doc and sign the CLA form. Please ping me here after you have done so. We are not allowed to use any individual open source contribution without that agreement. |
|
@raju-opti I believe I have already signed the CLA. optimizely/go-sdk#335 (comment) |
4d03caf to
8154ccd
Compare
|
Hello @kirkeaton , this has been merged as part of #942. This will be available in the next release. closing this PR. |

Summary
Removes
@babel/runtimeas a peerDependency which appears to be unused. It was added in #761 but it's not clear why.Test plan
Existing test should pass