fix: add notification center registry#413
Merged
andrewleap-optimizely merged 9 commits intomasterfrom Feb 3, 2023
Merged
Conversation
jaeopt
requested changes
Jan 27, 2023
Contributor
jaeopt
left a comment
There was a problem hiding this comment.
Changes look good. I see a case when sdk_key is not provided. See my comments.
optimizely/optimizely.py
Outdated
| if not self.sdk_settings.odp_disabled: | ||
| self._update_odp_config_on_datafile_update() | ||
| self.odp_manager: OdpManager | ||
| self.setup_odp(sdk_key or self.config_manager.get_sdk_key()) |
Contributor
There was a problem hiding this comment.
I see 2 changes related to "sdk_key" in here and in config_manager, both optional.
If none of them required, then we may have a case sdk_key is null.
As noted in my comment in config_manager, we may not need get_sdk_key in config_manager.
We can consider "sdk_key" in optimizely from optional to required while removing the changes in config_manager.
Contributor
|
@andrewleap-optimizely can we keep a note about this breaking change. We should release a major version bump with this note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create a private registry of NotificationCenters for internal use.
Test plan
added tests to
Ticket
FSSDK-8773