Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Exposing a new hook that is automatically called after a query execution has happened. This hook allows users to place custom logic to handle the results before they are returned back to the user. Situations where this may be useful is when dealing with PII and wanting to verify no information is sent back to the client that shouldn't, or maybe when you want to track how much data is being passed back to the user, audit logs, or more.
You may notice in this PR that we now pass the
Envaround as well so theafterQueryfunction has access to it. This allows developers to be able to create other Workers to handle the logic, and this piece of the code can use theEnvto access those service bindings. Helps encourage separation of concern code structure.Tasks
afterQueryfunction that can manipulate or observe query results before sending back to client.Verify
Before
After