Feat: Add support for creating git prototypes to cli. by dlabaj · Pull Request #12 · patternfly/patternfly-cli

dlabaj · 2026-02-10T16:47:02Z

Closes issue #7 :

Create projects and push initial project to prototype
Push updates to prototype
Retrieve latest updates from github.

…or github.

jpuzz0 · 2026-02-12T16:18:59Z

src/github.ts

+    'repo',
+    'create',
+    options.repoName,
+    '--public',


Do we want to provide an option to make a private project?

We could have a default...and maybe the default is public, but I would think maybe the opposite actually.

Good point let me update this to be private by default.

jpuzz0 · 2026-02-12T16:22:16Z

src/save.ts

+  }
+
+  try {
+    await execa('git', ['add', '.'], { cwd, stdio: 'inherit' });


Is there no selective adding ability? What if they only want to push a particular file or directory within the project?

After our meeting yesterday probably best to leave this out initially for the designer profile.

jpuzz0 · 2026-02-12T16:26:31Z

src/save.ts

+  ]);
+
+  const commitMessage = (message as string).trim();
+  if (!commitMessage) {


It seems this condition won't even be reached due to the validate function for the commit message above requiring a string, right? I think it can be removed, but maybe I'm misunderstanding.

yeah you're correct.

Was this updated with the latest changes? I think this problem still exists.

jpuzz0 · 2026-02-12T16:29:29Z

src/load.ts

+    if (err && typeof err === 'object' && 'exitCode' in err) {
+      const code = (err as { exitCode?: number }).exitCode;
+      if (code === 128) {
+        console.error(
+          '\n❌ Pull failed. You may need to set a remote (e.g. "git remote add origin <url>") or run "gh auth login".\n',
+        );
+      } else {
+        console.error('\n❌ Pull failed. See the output above for details.\n');
+      }
+    } else {
+      console.error('\n❌ An error occurred:');
+      if (err instanceof Error) console.error(`   ${err.message}\n`);
+      else console.error(`   ${String(err)}\n`);
+    }
+    throw err;


Seems this is duplicated in the save.ts file...instead of repeating the code here, maybe make a helper called something like handleGitError?

jpuzz0 · 2026-02-12T16:31:06Z

src/save.ts

+    console.log('\n✅ Changes saved and pushed to GitHub successfully.\n');
+  } catch (err) {
+    if (err && typeof err === 'object' && 'exitCode' in err) {
+      const code = (err as { exitCode?: number }).exitCode;


I think you can remove this casting if you update the condition above to something like if (err instanceof ExecaError) instead of if (err && typeof err === 'object' && 'exitCode' in err)

Looks like it could be other types of errors so updated to Error instead of ExecaError.

jpuzz0 · 2026-02-12T16:32:29Z

src/cli.ts

+        {
+          type: 'confirm',
+          name: 'useSSH',
+          message: 'Use SSH URL for cloning?',


Will non-devs understand this question and how to answer it?

removed the question you have to pass it in now.

jpuzz0 · 2026-02-12T16:37:35Z

src/cli.ts

Maybe the create logic could be separated into its own function to make the CLI more readable here, and could be unit tested separately.

makes sense.

jpuzz0 · 2026-02-18T21:16:52Z

src/save.ts

+    }
+
+    await execa('git', ['push'], { cwd, stdio: 'inherit' });
+    console.log('\n✅ Changes saved and pushed to GitHub successfully.\n');


If the commit succeeds on line 64 but push fails here, the user sees an error and might think nothing was saved. Worth letting them know their changes were committed locally?

jpuzz0 · 2026-02-18T21:16:52Z

src/save.ts

+      } else {
+        console.error('\n❌ Save or push failed. See the output above for details.\n');
+      }
+    } else if (!(err instanceof Error && err.message === 'No remote origin')) {


This couples the catch to the exact string 'No remote origin' — if someone changes the message on line 80, the catch silently starts double-logging. Would a custom error class make this safer?

jpuzz0 · 2026-02-18T21:16:53Z

src/save.ts

+    await execa('git', ['push'], { cwd, stdio: 'inherit' });
+    console.log('\n✅ Changes saved and pushed to GitHub successfully.\n');
+  } catch (err) {
+    if (err && typeof err === 'object' && 'exitCode' in err) {


This error narrowing pattern is duplicated in load.ts too — maybe a shared isExecaError helper?

jpuzz0 · 2026-02-18T21:16:53Z

src/github.ts

+  try {
+    await execa('gh', ['api', `repos/${owner}/${repoName}`], { reject: true });
+    return true;
+  } catch {


repoExists returns false for any error, not just "repo doesn't exist." A network timeout or auth failure would silently proceed to create a repo that might already exist. Should non-404 errors be surfaced?

jpuzz0 · 2026-02-18T21:16:53Z

src/github.ts

+  }
+
+  const pkgJson = await fs.readJson(pkgJsonPath);
+  const projectName = (pkgJson.name as string) ?? 'my-project';


?? 'my-project' only catches null/undefined — if name is an empty string in a bad package.json, sanitizeRepoName gets it. Worth a more defensive check?

jpuzz0 · 2026-02-18T21:16:53Z

src/github.ts

+    '--public',
+    `--source=${options.projectPath}`,
+    '--remote=origin',
+    '--push',


createRepo passes --push here, but when called from save, the flow also does git push after. Isn't the second push redundant?

jpuzz0 · 2026-02-18T21:16:53Z

src/load.ts

+
+  try {
+    console.log('📥 Pulling latest updates from GitHub...\n');
+    await execa('git', ['pull'], { cwd, stdio: 'inherit' });


Will beginners understand git's error when no upstream tracking branch is set? Might be worth a friendlier message.

jpuzz0 · 2026-02-18T21:21:22Z

src/save.ts

+  ]);
+
+  const commitMessage = (message as string).trim();
+  if (!commitMessage) {


Was this updated with the latest changes? I think this problem still exists.

dlabaj · 2026-02-18T21:48:30Z

Capturing outstanding comments in follow up issue and merging this issue.

dlabaj added 2 commits February 9, 2026 16:20

Added new git ssh additon.

232f74f

feat: Added support for creating a repo and pushing your project to f…

e627bed

…or github.

dlabaj self-assigned this Feb 10, 2026

dlabaj added this to PatternFly Issues Feb 10, 2026

dlabaj added the enhancement New feature or request label Feb 10, 2026

github-project-automation bot moved this to Needs triage in PatternFly Issues Feb 10, 2026

dlabaj added 4 commits February 10, 2026 14:57

fixed broken unit tests. mock for execa was undefined before.

48503ae

Fixed bug with github command when creating a repo.

c379a89

Added save command that pushes to remote repo.

8a8acd3

Added load command to sync repo with github.

8cb78cc

dlabaj changed the title ~~WIP: Add support for creating git prototypes to cli.~~ Feat: Add support for creating git prototypes to cli. Feb 12, 2026

dlabaj requested review from cdcabrera and jpuzz0 and removed request for cdcabrera and jpuzz0 February 12, 2026 14:20

jpuzz0 reviewed Feb 12, 2026

View reviewed changes

feat: fixed some issues with save and load.

441ab36

jpuzz0 reviewed Feb 18, 2026

View reviewed changes

dlabaj merged commit 4cd82e1 into main Feb 18, 2026

github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Feb 18, 2026

Conversation

dlabaj commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dlabaj commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

dlabaj commented Feb 10, 2026 •

edited

Loading