chore(Toolbar): replaced chip instances with label#10649
Merged
tlabaj merged 3 commits intopatternfly:v6from Jul 8, 2024
Merged
chore(Toolbar): replaced chip instances with label#10649tlabaj merged 3 commits intopatternfly:v6from
tlabaj merged 3 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-10649.surge.sh A11y report: https://patternfly-react-pr-10649-a11y.surge.sh |
kmcfaul
approved these changes
Jun 26, 2024
Contributor
kmcfaul
left a comment
There was a problem hiding this comment.
Yep, changes lgtm. It was a little beyond the scope of the initial chip replacement work, hence the follow up issue.
tlabaj
approved these changes
Jul 3, 2024
Contributor
|
Just needs a rebase. |
237a657 to
886c704
Compare
886c704 to
db4531e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10405
Codemod issue: patternfly/pf-codemods#673
Additional issues: