fix(Wizard): add className props and spread them when possible#10670
Merged
tlabaj merged 3 commits intopatternfly:v6from Jul 1, 2024
Merged
fix(Wizard): add className props and spread them when possible#10670tlabaj merged 3 commits intopatternfly:v6from
tlabaj merged 3 commits intopatternfly:v6from
Conversation
Collaborator
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Tests for these added props would be great to have IMO, but other than that and it looking like the lock file needs an update LGTM.
kmcfaul
approved these changes
Jun 27, 2024
Contributor
kmcfaul
left a comment
There was a problem hiding this comment.
changes lgtm once build goes through
Contributor
Author
|
I'll add tests later today 👍🏻 |
Collaborator
|
Preview: https://patternfly-react-pr-10670.surge.sh A11y report: https://patternfly-react-pr-10670-a11y.surge.sh |
tlabaj
reviewed
Jun 27, 2024
Contributor
tlabaj
left a comment
There was a problem hiding this comment.
Can you also make this change on main.
thatblindgeye
approved these changes
Jun 27, 2024
tlabaj
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10665
unblocks an issue in quickstarts v6 migrations