fix(textarea): fix height logic for autoresize textarea#11922
Merged
nicolethoen merged 2 commits intopatternfly:mainfrom Jul 25, 2025
Merged
fix(textarea): fix height logic for autoresize textarea#11922nicolethoen merged 2 commits intopatternfly:mainfrom
nicolethoen merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11922.surge.sh A11y report: https://patternfly-react-pr-11922-a11y.surge.sh |
kmcfaul
approved these changes
Jul 16, 2025
Contributor
|
Will take a second look to double check on the snapshot update |
Contributor
|
I think the snapshot is probably fine, it must have snapshotted during the intermediate step in the calc where it sets 'height: inherit' opposed to post-calc. It's possible that it's a testing env quirk where maybe the window computed styles returns something invalid. The fix looks to be working on the preview. |
dlabaj
approved these changes
Jul 18, 2025
nicolethoen
approved these changes
Jul 25, 2025
16 tasks
nicolethoen
pushed a commit
that referenced
this pull request
Aug 4, 2025
* fix(textarea): fix height logic for autoresize textarea * fix(textarea): update snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11921
Additional issues: https://issues.redhat.com/browse/AAP-47692
For consideration - 2 options for pulling this fix into Core as described by @mcoker but would change the markup so be potentially breaking:
Option 1:
box-sizing: content-boxstyle to the existingstyle="height: {n}px"attribute in the rendered page markup (breaking?)Option 2: - same as option 1, but instead of adding
box-sizing: content-boxas an inline style, we add a class in core/react (.pf-m-auto-resize) that sets that style for us.pf-m-auto-resizeprobably on the other form control wrapper