feat(Popper): add passthrough for offset#11994
Merged
wise-king-sullyman merged 2 commits intopatternfly:mainfrom Sep 10, 2025
Merged
feat(Popper): add passthrough for offset#11994wise-king-sullyman merged 2 commits intopatternfly:mainfrom
wise-king-sullyman merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://pf-react-pr-11994.surge.sh A11y report: https://pf-react-pr-11994-a11y.surge.sh |
Venefilyn
reviewed
Sep 8, 2025
Comment on lines
110
to
111
| /** Override for the popper's offset */ | ||
| offset?: [number, number]; |
Contributor
There was a problem hiding this comment.
Should also allow a function which is what we want to use in Cockpit. Can we do something like this?
Suggested change
| /** Override for the popper's offset */ | |
| offset?: [number, number]; | |
| /** Override for the popper's offset */ | |
| offset?: OffsetOptions['offset']; |
Then import it at the beginning, I assume this but maybe there is a better import path to use
import { Options as OffsetOptions } from './thirdparty/popper-core/modifiers/offset';
thatblindgeye
approved these changes
Sep 10, 2025
wise-king-sullyman
approved these changes
Sep 10, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #11987
Adds a passthrough for Popper's
offset(distancemay still be used and still remains as a default ifoffsetisn't present).