Skip to content

feat(react-icons): add newest rh brand icons#12222

Merged
mcoker merged 2 commits intopatternfly:mainfrom
nicolethoen:add_more_icons
Feb 2, 2026
Merged

feat(react-icons): add newest rh brand icons#12222
mcoker merged 2 commits intopatternfly:mainfrom
nicolethoen:add_more_icons

Conversation

@nicolethoen
Copy link
Contributor

@nicolethoen nicolethoen commented Jan 29, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Expanded icon library with 60+ new icons, including AI-related icons (chat, create, edit, enhance, search, troubleshoot), device icons (laptop, tablet, mobile phone), and additional standard icons for transportation, tools, and other use cases.

  • Chores

    • Updated icon generation tools to support ES modules.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026 •
edited
Loading

Walkthrough

The PR updates the React icons package to use @rhds/icons v2.1.0, adds a build helper script to ensure proper ES module package.json configuration, modifies the build process to run this helper before generating icons, and expands the available icon set by adding hundreds of new icon definitions to both the standard and UI icon libraries.

Changes

Cohort / File(s) Summary
Dependency Updates
package.json, packages/react-icons/package.json		 Bumped devDependency @rhds/icons from ^2.0.0 to ^2.1.0. Added update-rhds-icons npm script. Modified generate script to run ensureEsmPackageJson.mjs before writeIcons.mjs.
Build Tooling
packages/react-icons/scripts/ensureEsmPackageJson.mjs		 New ES Module helper script that creates the dist/esm directory and writes a package.json with { "type": "module" } to ensure proper ES module configuration.
Icon Definitions
packages/react-icons/scripts/icons/rhIconsStandard.mjs, packages/react-icons/scripts/icons/rhIconsUI.mjs		 Expanded icon libraries with hundreds of new icon definitions. Added 427 new standard icons and 234 new UI icons, each containing xOffset, yOffset, width, height, and svgPathData properties following consistent patterns.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • mcoker
  • lboehling
  • thatblindgeye
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately reflects the main change: adding new RH brand icons to the react-icons package, which is evident from the additions to rhIconsStandard.mjs and rhIconsUI.mjs icon definition files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Jan 29, 2026 •
edited
Loading

Preview: https://pf-react-pr-12222.surge.sh

A11y report: https://pf-react-pr-12222-a11y.surge.sh

@gitdallas
Copy link
Contributor

gitdallas commented Feb 2, 2026

added my worthless grey checkmark 🤷

@gitdallas gitdallas requested a review from mcoker February 2, 2026 19:47
mcoker
mcoker approved these changes Feb 2, 2026
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons all look good to me 🎉

@mcoker mcoker merged commit f3613a6 into patternfly:main Feb 2, 2026
14 checks passed
This was referenced Feb 16, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

+1 more reviewer

@gitdallas gitdallas gitdallas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolethoen @patternfly-build @gitdallas @mcoker @kmcfaul

Comments